Decouple configuration store from scraping service #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
configstore
branch
2 times, most recently
from
edb116f
to
a01ab53
Compare
|
Taking this out of draft. I think we can merge it in this state and follow up with a few more PRs to hook it in. |
mattdurham
approved these changes
Mar 3, 2021
| if otherConfig.Name == cfg.Name { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
Not in love with this, but I cant think of a better way to do it with the default set of golang collections.
There was a problem hiding this comment.
I don't like the uniqueness checking at all honestly. We have #398 in the backlog to try to avoid this altogether
3 tasks
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* initial commit of a configstore * review feedback
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR starts the work of decoupling the configuration store from the scraping service. This will eventually be needed to make the KV-based configuration store optional, but is more immediately useful to
/-/reload(#147) where we may want to dynamically update the configuration for a store.Which issue(s) this PR fixes
Related to #147.
Notes to the Reviewer
Not hooked in yet. I didn't want to delete too much code from
pkg/prom/haso this didn't become too hard to review.The HTTP API for the config store would move to this new package too.
Tagging @mattdurham and @56quarters to get some early thoughts. This will be a pretty drastic change from how the scraping service was handled before.